Very nice cleanup.
lgtm with minor comments
https://codereview.chromium.org/895053002/diff/300001/src/api-natives.cc
File src/api-natives.cc (right):
https://codereview.chromium.org/895053002/diff/300001/src/api-natives.cc#newcode133
src/api-natives.cc:133: // standard.
Would indeed be nice if you'd just move the Disable/Enable access checks
out of this function in a wrapper.
https://codereview.chromium.org/895053002/diff/300001/src/api-natives.cc#newcode148
src/api-natives.cc:148: AddPropertyForTemplate(isolate, obj, name,
value, attributes);
Can you change this to return a MaybeHandle<> rather than checking
IsException? That's the C++ side of the exception API.
https://codereview.chromium.org/895053002/diff/300001/src/api-natives.cc#newcode162
src/api-natives.cc:162: setter, attributes);
Same here
https://codereview.chromium.org/895053002/diff/300001/src/api-natives.cc#newcode205
src/api-natives.cc:205: Handle<FixedArray>
cache(isolate->native_context()->function_cache());
auto cache = isolate->function_cache();
https://codereview.chromium.org/895053002/diff/300001/src/api-natives.cc#newcode206
src/api-natives.cc:206: if
(isolate->native_context()->function_cache()->length() <= serial_number)
{
cache->length()
https://codereview.chromium.org/895053002/diff/300001/src/api-natives.cc#newcode226
src/api-natives.cc:226: Handle<FixedArray>
cache(isolate->native_context()->function_cache());
auto cache = isolate->function_cache()
https://codereview.chromium.org/895053002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
