https://codereview.chromium.org/893073006/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/893073006/diff/1/src/hydrogen-instructions.h#newcode6404
src/hydrogen-instructions.h:6404: ReadBarrierField::encode(read_barrier
? 1 : 0) |
I like that.

https://codereview.chromium.org/893073006/diff/1/src/ia32/macro-assembler-ia32.cc
File src/ia32/macro-assembler-ia32.cc (right):

https://codereview.chromium.org/893073006/diff/1/src/ia32/macro-assembler-ia32.cc#newcode2429
src/ia32/macro-assembler-ia32.cc:2429: // indicates the cell has been
read from.
This seems to be more expensive than just clearing a bit. The advantage
is, that we do not slow down the case when we can go directly to the
value (omit read barrier). I guess we have to measure the performance
impact.

https://codereview.chromium.org/893073006/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to