Reviewers: Sven Panne,

Message:
svenpanne, ptal. This is an old-ish problem, this CL is trying to make the API
consistent with scanner character streams. The downside is that the border
between size_t and other random types V8 uses will always be somewhere until all
of it is fixed... so this is a stab at moving it forward.

Description:
Scanner / Unicode decoding: use size_t instead of unsigned.

size_t is the correct data type for this purpose. Our APIs (in particular
ExternalSourceStream::GetMoreData) are already using it, and there were some
static_casts to convert between them.

This CL doesn't intend to fix all of V8, just the minimal sense-making part
around scanner character streams.

BUG=

Please review this at https://codereview.chromium.org/864273005/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+142, -154 lines):
  M src/factory.cc
  M src/heap-snapshot-generator.cc
  M src/heap/heap.cc
  M src/objects.cc
  M src/scanner.h
  M src/scanner-character-streams.h
  M src/scanner-character-streams.cc
  M src/unicode.h
  M src/unicode.cc
  M src/unicode-decoder.h
  M src/unicode-decoder.cc
  M src/unicode-inl.h
  M src/utils.h
  M test/cctest/test-parsing.cc


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to