Reviewers: Mads Ager, Description: Add a check to make sure we never mis-report being in context while creating it anew.
Occasionally, creating new context may trigger garbage collection, which in turn reaches back into V8 bindings during the prologue, where we can occasionally call ask for context, which makes us use incomplete context (or ASSERT in Debug). R=ager BUG=25747 TEST=random crashes on build bots should go away. Please review this at http://codereview.chromium.org/348001 SVN Base: http://v8.googlecode.com/svn/trunk/ Affected files: M src/api.cc Index: src/api.cc =================================================================== --- src/api.cc (revision 3121) +++ src/api.cc (working copy) @@ -2754,7 +2754,7 @@ bool Context::InContext() { - return i::Top::context() != NULL; + return !i::Bootstrapper::IsActive() && i::Top::context() != NULL; } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
