On 2015/02/04 19:15:42, dcarney wrote:
On 2015/02/04 15:16:54, yurys wrote:
> The error looks weird to me. C4251 warning disabled in several build
> configurations [1], should we do the same for v8? Otherwise I would
have to
> somehow instantiate v8::UniquePersistent<v8::Object> in v8.h and mark
that
class
> as exported.
>
>
> [1]
>
https://code.google.com/p/chromium/codesearch#search/&q=C4251&sq=package:chromium&type=cs
it's generally a bad idea to embed handles into objects. It's completely
contrary to of the way the rest of the api is written. in this case, you
could
make the class extend Data, since you want to pretend it's not in the js
class
hierachy and you wouldn't run into the windows warning.
Thanks for your comments, you are absolutely right. Fixed version is up at
https://codereview.chromium.org/900123003/
https://codereview.chromium.org/891473005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
