Love it, but I'd be a little more careful with removing pre-generated stubs
(see
below).
https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc
File src/ic/ic-state.cc (left):
https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc#oldcode124
src/ic/ic-state.cc:124: GENERATE(Token::ADD, SMI, SMI, INT32,
OVERWRITE_LEFT);
I would assume that we want to keep the SMI,SMI,INT32 and SMI,SMI,SMI
variants (just without any OVERWRITE flag).
https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc#oldcode136
src/ic/ic-state.cc:136: GENERATE(Token::BIT_AND, NUMBER, INT32, INT32,
OVERWRITE_RIGHT);
keep this?
https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc#oldcode140
src/ic/ic-state.cc:140: GENERATE(Token::BIT_AND, SMI, INT32, SMI,
OVERWRITE_RIGHT);
keep this?
https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc#oldcode141
src/ic/ic-state.cc:141: GENERATE(Token::BIT_AND, SMI, NUMBER, SMI,
OVERWRITE_RIGHT);
keep this?
Ah, you know what, instead of manually comparing all these lines, let me
suggest the following algorithm to be applied to the old code:
1.) s/, NO_OVERWRITE//, s/, OVERWRITE_LEFT//, s/, OVERWRITE_RIGHT//
2.) sort | uniq
https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.h
File src/ic/ic-state.h (right):
https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.h#newcode144
src/ic/ic-state.h:144: class ResultKindField : public BitField<Kind, 6,
3> {};
Please either insert a comment that bits 4 and 5 are unused, or shift up
the remaining BitFields to close the gap.
https://codereview.chromium.org/900193002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
