Thanks for comments. All done. Now stronger than ever.
https://codereview.chromium.org/898983002/diff/1/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/898983002/diff/1/src/globals.h#newcode245
src/globals.h:245: inline bool is_sloppy(LanguageMode language_mode) {
On 2015/02/04 16:18:08, rossberg wrote:
Nit: perhaps reorder methods.
Done.
https://codereview.chromium.org/898983002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/898983002/diff/1/src/parser.cc#newcode1156
src/parser.cc:1156: bool use_sanity_found =
On 2015/02/04 16:17:11, arv wrote:
Don't we want a flag for this work?
Done.
https://codereview.chromium.org/898983002/diff/1/src/parser.cc#newcode1157
src/parser.cc:1157: !use_strict_found && !is_sane(language_mode()) &&
On 2015/02/04 16:18:09, rossberg wrote:
If I read this correctly then
"use sanity"; "use strict";
will turn on sane mode, while
"use strict"; "use sanity";
will leave you in strict mode. That would be weird. I think it should
be fine to
redundantly have both directives in either order.
Done. (Oops, preparser was already following that logic.)
https://codereview.chromium.org/898983002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/898983002/diff/1/test/cctest/test-parsing.cc#newcode4998
test/cctest/test-parsing.cc:4998: {NULL, NULL}};
On 2015/02/04 16:18:09, rossberg wrote:
Maybe add a test checking multiple directives.
Done.
https://codereview.chromium.org/898983002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
