lgtm % a few nits/questions
Might as well also mention removing the (mostly-unused, it seems) helper
methods
in the CL description.
https://codereview.chromium.org/883073008/diff/40001/src/code-stubs.h
File src/code-stubs.h (left):
https://codereview.chromium.org/883073008/diff/40001/src/code-stubs.h#oldcode598
src/code-stubs.h:598: class FunctionKindBits : public
BitField<FunctionKind, 2, 4> {};
Out of curiosity, was this just busted before?
https://codereview.chromium.org/883073008/diff/40001/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/883073008/diff/40001/src/globals.h#newcode823
src/globals.h:823: kSubclassConstructor = 32
Maybe switch to shift-lefts now that this is getting big?
https://codereview.chromium.org/883073008/diff/40001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (left):
https://codereview.chromium.org/883073008/diff/40001/src/hydrogen-instructions.h#oldcode7619
src/hydrogen-instructions.h:7619: class FunctionKindField : public
BitField<FunctionKind, 0, 4> {};
Same question here?
https://codereview.chromium.org/883073008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
