https://codereview.chromium.org/866843003/diff/40001/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/866843003/diff/40001/src/serialize.cc#newcode912
src/serialize.cc:912: if (rmode == RelocInfo::INTERNAL_REFERENCE) {
I'm quite puzzled by this. It is true that V8 currently does not use
INTERNAL_REFERENCE. This however may change soon if we decide to
implement jump tables. I'm currently looking at ways to implement
serialization in a generalized way.
I think what you are assuming here is that every INTERNAL_REFERENCE in
PPC code is a function descriptor (if I understood correctly, a pointer
to self), so you simply go through all internal references and replace
them by the updated self pointer.
This would not work for arbitrary internal references, and I think this
should be solved differently.
Furthermore, adding this piece of platform-dependent code here is bad
style.
https://codereview.chromium.org/866843003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
