LGTM.
http://codereview.chromium.org/342035/diff/1/12 File src/arm/fast-codegen-arm.cc (right): http://codereview.chromium.org/342035/diff/1/12#newcode179 Line 179: ASSERT_EQ(Expression::kValue, expr->context()); Why are you dropping the optimization for a constant literal here? http://codereview.chromium.org/342035/diff/1/8 File src/compiler.cc (right): http://codereview.chromium.org/342035/diff/1/8#newcode58 Line 58: void ProcessExpression(Expression::Context context, Expression* expr) { Could this be called VisitExpression? I think the expression should be the first argument, and how you visit it should be the second. http://codereview.chromium.org/342035/diff/1/6 File src/ia32/fast-codegen-ia32.cc (right): http://codereview.chromium.org/342035/diff/1/6#newcode168 Line 168: __ pop(eax); Restore optimization? http://codereview.chromium.org/342035/diff/1/9 File src/x64/fast-codegen-x64.cc (left): http://codereview.chromium.org/342035/diff/1/9#oldcode463 Line 463: Location destination = expr->location(); Why wasn't this giving an "unused" warning before? http://codereview.chromium.org/342035 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
