On 2015/02/06 07:37:28, Sven Panne wrote:
LGTM with nits.
https://codereview.chromium.org/866553003/diff/40001/src/runtime/runtime-maths.cc
File src/runtime/runtime-maths.cc (right):
https://codereview.chromium.org/866553003/diff/40001/src/runtime/runtime-maths.cc#newcode70
src/runtime/runtime-maths.cc:70: double* y =
reinterpret_cast<double*>(backing_store);
A static_cast is enough here and a smaller sledgehammer for the task at
hand.
;-) Perhaps one should templatize backing_store(), most uses have to cast,
anyway (but this would definitely be a separate CL).
https://codereview.chromium.org/866553003/diff/40001/src/runtime/runtime-maths.cc#newcode72
src/runtime/runtime-maths.cc:72: return Smi::FromInt(n);
Just inline "n", its name is not that helpful, anyway.
https://codereview.chromium.org/866553003/diff/40001/src/third_party/fdlibm/fdlibm.js
File src/third_party/fdlibm/fdlibm.js (right):
https://codereview.chromium.org/866553003/diff/40001/src/third_party/fdlibm/fdlibm.js#newcode27
src/third_party/fdlibm/fdlibm.js:27: var rempio2result;
Extend the comment above.
Addressed comments.
https://codereview.chromium.org/866553003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
