Reviewers: dcarney,
Description:
Const-corrected some MachineSignature* parameters.
Recipe: Add "const" to RawMachineAssembler constructor, fix breakage.
Please review this at https://codereview.chromium.org/874693006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+17, -16 lines):
M src/compiler/arm/linkage-arm.cc
M src/compiler/arm64/linkage-arm64.cc
M src/compiler/ia32/linkage-ia32.cc
M src/compiler/linkage.h
M src/compiler/linkage-impl.h
M src/compiler/mips/linkage-mips.cc
M src/compiler/mips64/linkage-mips64.cc
M src/compiler/ppc/linkage-ppc.cc
M src/compiler/raw-machine-assembler.h
M src/compiler/raw-machine-assembler.cc
M src/compiler/x64/linkage-x64.cc
Index: src/compiler/arm/linkage-arm.cc
diff --git a/src/compiler/arm/linkage-arm.cc
b/src/compiler/arm/linkage-arm.cc
index
ddc94626b788eef66996acce118a11e43387d30d..0d9ca12d991ed4acecb7f7e295f09d3bf4fb3911
100644
--- a/src/compiler/arm/linkage-arm.cc
+++ b/src/compiler/arm/linkage-arm.cc
@@ -60,7 +60,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
- MachineSignature* sig) {
+ const MachineSignature*
sig) {
return LH::GetSimplifiedCDescriptor(zone, sig);
}
Index: src/compiler/arm64/linkage-arm64.cc
diff --git a/src/compiler/arm64/linkage-arm64.cc
b/src/compiler/arm64/linkage-arm64.cc
index
352a4bcd969c50873235f7175c47cbbf9f6b9e22..142d8dd2e37d8e467a13c6def0de7b93ab1af8b9
100644
--- a/src/compiler/arm64/linkage-arm64.cc
+++ b/src/compiler/arm64/linkage-arm64.cc
@@ -60,7 +60,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
- MachineSignature* sig) {
+ const MachineSignature*
sig) {
return LH::GetSimplifiedCDescriptor(zone, sig);
}
Index: src/compiler/ia32/linkage-ia32.cc
diff --git a/src/compiler/ia32/linkage-ia32.cc
b/src/compiler/ia32/linkage-ia32.cc
index
2b57f1dbd348e537f2df77a1faa8ca1af7115418..aaf954497b5b3ce0c17c14a7863fd59fbe974ae2
100644
--- a/src/compiler/ia32/linkage-ia32.cc
+++ b/src/compiler/ia32/linkage-ia32.cc
@@ -55,7 +55,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
- MachineSignature* sig) {
+ const MachineSignature*
sig) {
return LH::GetSimplifiedCDescriptor(zone, sig);
}
Index: src/compiler/linkage-impl.h
diff --git a/src/compiler/linkage-impl.h b/src/compiler/linkage-impl.h
index
b270664c7fb43cf9ca5b8c61f8792e74fa60b4de..abd0696837d17a49c4f58e1d9ca8084968658069
100644
--- a/src/compiler/linkage-impl.h
+++ b/src/compiler/linkage-impl.h
@@ -192,8 +192,8 @@ class LinkageHelper {
descriptor.DebugName(isolate));
}
- static CallDescriptor* GetSimplifiedCDescriptor(Zone* zone,
- MachineSignature* msig) {
+ static CallDescriptor* GetSimplifiedCDescriptor(
+ Zone* zone, const MachineSignature* msig) {
LocationSignature::Builder locations(zone, msig->return_count(),
msig->parameter_count());
// Add return location(s).
Index: src/compiler/linkage.h
diff --git a/src/compiler/linkage.h b/src/compiler/linkage.h
index
8d529323af61d01de9e7106fa52e0412586f20c6..248391f8a52c278d66f63ce321d10b1316d9de2a
100644
--- a/src/compiler/linkage.h
+++ b/src/compiler/linkage.h
@@ -64,8 +64,9 @@ class CallDescriptor FINAL : public ZoneObject {
typedef base::Flags<Flag> Flags;
CallDescriptor(Kind kind, MachineType target_type, LinkageLocation
target_loc,
- MachineSignature* machine_sig, LocationSignature*
location_sig,
- size_t js_param_count, Operator::Properties properties,
+ const MachineSignature* machine_sig,
+ LocationSignature* location_sig, size_t js_param_count,
+ Operator::Properties properties,
RegList callee_saved_registers, Flags flags,
const char* debug_name = "")
: kind_(kind),
@@ -209,7 +210,7 @@ class Linkage : public ZoneObject {
// integers and pointers of one word size each, i.e. no floating point,
// structs, pointers to members, etc.
static CallDescriptor* GetSimplifiedCDescriptor(Zone* zone,
- MachineSignature* sig);
+ const MachineSignature*
sig);
// Get the location of an (incoming) parameter to this function.
LinkageLocation GetParameterLocation(int index) const {
Index: src/compiler/mips/linkage-mips.cc
diff --git a/src/compiler/mips/linkage-mips.cc
b/src/compiler/mips/linkage-mips.cc
index
4602eebf2121521363815c280db9829612814d9c..1534b0bdd54382d09af64437a5aa3b2b09df2ba4
100644
--- a/src/compiler/mips/linkage-mips.cc
+++ b/src/compiler/mips/linkage-mips.cc
@@ -60,7 +60,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
- MachineSignature* sig) {
+ const MachineSignature*
sig) {
return LH::GetSimplifiedCDescriptor(zone, sig);
}
Index: src/compiler/mips64/linkage-mips64.cc
diff --git a/src/compiler/mips64/linkage-mips64.cc
b/src/compiler/mips64/linkage-mips64.cc
index
47faaa6084c15cf47d3d1499713bcc20b0ba93c1..b10ee2f7eea4ad12a2bd0e6a7e56f9ab98517bc8
100644
--- a/src/compiler/mips64/linkage-mips64.cc
+++ b/src/compiler/mips64/linkage-mips64.cc
@@ -60,7 +60,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
- MachineSignature* sig) {
+ const MachineSignature*
sig) {
return LH::GetSimplifiedCDescriptor(zone, sig);
}
Index: src/compiler/ppc/linkage-ppc.cc
diff --git a/src/compiler/ppc/linkage-ppc.cc
b/src/compiler/ppc/linkage-ppc.cc
index
96dcaaa5b2bc6df16b438ce94d70de1833da2a6a..1008981ff7f0f589a1899c13b8ee56ca1c9b2c6c
100644
--- a/src/compiler/ppc/linkage-ppc.cc
+++ b/src/compiler/ppc/linkage-ppc.cc
@@ -62,7 +62,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
- MachineSignature* sig) {
+ const MachineSignature*
sig) {
return LH::GetSimplifiedCDescriptor(zone, sig);
}
Index: src/compiler/raw-machine-assembler.cc
diff --git a/src/compiler/raw-machine-assembler.cc
b/src/compiler/raw-machine-assembler.cc
index
25264454736be18f7a86997ab081b172f8cee982..5782eba57410ef5ffbf18347a015c0920b5d4116
100644
--- a/src/compiler/raw-machine-assembler.cc
+++ b/src/compiler/raw-machine-assembler.cc
@@ -12,7 +12,7 @@ namespace internal {
namespace compiler {
RawMachineAssembler::RawMachineAssembler(Isolate* isolate, Graph* graph,
- MachineSignature* machine_sig,
+ const MachineSignature*
machine_sig,
MachineType word,
MachineOperatorBuilder::Flags
flags)
: GraphBuilder(isolate, graph),
Index: src/compiler/raw-machine-assembler.h
diff --git a/src/compiler/raw-machine-assembler.h
b/src/compiler/raw-machine-assembler.h
index
7b4644497ea9feb1c85047e0b4be74bc51efa024..ef1f31ce8b2490635d32aa0a3e93dc50b44b48a3
100644
--- a/src/compiler/raw-machine-assembler.h
+++ b/src/compiler/raw-machine-assembler.h
@@ -45,7 +45,7 @@ class RawMachineAssembler : public GraphBuilder {
};
RawMachineAssembler(Isolate* isolate, Graph* graph,
- MachineSignature* machine_sig,
+ const MachineSignature* machine_sig,
MachineType word = kMachPtr,
MachineOperatorBuilder::Flags flags =
MachineOperatorBuilder::Flag::kNoFlags);
@@ -56,7 +56,7 @@ class RawMachineAssembler : public GraphBuilder {
CommonOperatorBuilder* common() { return &common_; }
CallDescriptor* call_descriptor() const { return call_descriptor_; }
size_t parameter_count() const { return machine_sig_->parameter_count();
}
- MachineSignature* machine_sig() const { return machine_sig_; }
+ const MachineSignature* machine_sig() const { return machine_sig_; }
Node* UndefinedConstant() {
Unique<HeapObject> unique = Unique<HeapObject>::CreateImmovable(
@@ -448,7 +448,7 @@ class RawMachineAssembler : public GraphBuilder {
Schedule* schedule_;
MachineOperatorBuilder machine_;
CommonOperatorBuilder common_;
- MachineSignature* machine_sig_;
+ const MachineSignature* machine_sig_;
CallDescriptor* call_descriptor_;
Node** parameters_;
Label exit_label_;
Index: src/compiler/x64/linkage-x64.cc
diff --git a/src/compiler/x64/linkage-x64.cc
b/src/compiler/x64/linkage-x64.cc
index
abd332fd50259504a7b1034dbb059b6b38c8f98a..45dc931c762e5fc287c478ba24ef6d6fe6f1be20
100644
--- a/src/compiler/x64/linkage-x64.cc
+++ b/src/compiler/x64/linkage-x64.cc
@@ -74,7 +74,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
- MachineSignature* sig) {
+ const MachineSignature*
sig) {
return LH::GetSimplifiedCDescriptor(zone, sig);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
