I like the idea a lot. But I am a bit worried about the code pollution.
Additionally to the gc_tracer, we would have to maintain these type of
tracing
calls as well. Would it make sense to integrate some of the calls (e.g. for
the
roots) in the GCTracer? That would mean we would have to add more GCTracer
calls
but at least some of the calls would handle both. Not sure if this is
cleaner...
WDYT?
https://codereview.chromium.org/890663005/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/890663005/diff/40001/src/heap/heap.cc#newcode5610
src/heap/heap.cc:5610: if (mark_sweeps > 5 && WeakCell::cast(dc->get(i +
1))->value() == obj) {
make 5 a constant
https://codereview.chromium.org/890663005/diff/40001/src/heap/heap.cc#newcode5625
src/heap/heap.cc:5625:
+1 newline
https://codereview.chromium.org/890663005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
