LGTM with comments.
https://codereview.chromium.org/892953004/diff/60001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/892953004/diff/60001/test/cctest/test-cpu-profiler.cc#newcode53
test/cctest/test-cpu-profiler.cc:53: static v8::Handle<v8::Script>
Compile(const char* utf8_source) {
Can we use v8_compile for this?
https://codereview.chromium.org/892953004/diff/60001/test/cctest/test-cpu-profiler.cc#newcode58
test/cctest/test-cpu-profiler.cc:58: static v8::Local<v8::Function>
GetFunction(LocalContext& env,
Can we drop this one and always use the one below? IIUC it only requires
one additional '*' character.
https://codereview.chromium.org/892953004/diff/60001/test/cctest/test-cpu-profiler.cc#newcode561
test/cctest/test-cpu-profiler.cc:561:
Compile(cpu_profiler_test_source)->Run();
Can we use CompileRun() here and for the other occurences below?
https://codereview.chromium.org/892953004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
