lgtm with some more cleanup mentioned if you feel like it.
https://codereview.chromium.org/905003003/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/905003003/diff/1/src/preparser.h#newcode1622
src/preparser.h:1622: SourceElements ParseStatementList(int end_token,
bool* ok);
You could also rename the return value, although it's pretty confusing
no matter what the name is.
Actually, could you just get rid of the enum altogether and make this
return void? We already have to redefine the CHECK_OK macro to make the
SourceElements thing work.
https://codereview.chromium.org/905003003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
