Reviewers: Weiliang,
Message:
PTAL.
thanks
Description:
X87: Initial switch to Chromium-style CHECK_* and DCHECK_* macros
port 0deaa4b629faeae6832046c294dc7c034a0a6653 (r26340)
(code change in full-codegen-x87.cc is covered by r26340 ).
original commit message:
Initial switch to Chromium-style CHECK_* and DCHECK_* macros.
BUG=
Please review this at https://codereview.chromium.org/903353002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -2 lines):
M src/x87/code-stubs-x87.cc
M src/x87/lithium-codegen-x87.cc
Index: src/x87/code-stubs-x87.cc
diff --git a/src/x87/code-stubs-x87.cc b/src/x87/code-stubs-x87.cc
index
28baf49fabc314eab7ba8d389d82c1cde94a60fe..e60060d4f0d5bf238234c060675b1c23b6a2f5a9
100644
--- a/src/x87/code-stubs-x87.cc
+++ b/src/x87/code-stubs-x87.cc
@@ -1381,7 +1381,7 @@ void CompareICStub::GenerateGeneric(MacroAssembler*
masm) {
// If either is a Smi (we know that not both are), then they can only
// be equal if the other is a HeapNumber. If so, use the slow case.
STATIC_ASSERT(kSmiTag == 0);
- DCHECK_EQ(0, Smi::FromInt(0));
+ DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0));
__ mov(ecx, Immediate(kSmiTagMask));
__ and_(ecx, eax);
__ test(ecx, edx);
Index: src/x87/lithium-codegen-x87.cc
diff --git a/src/x87/lithium-codegen-x87.cc b/src/x87/lithium-codegen-x87.cc
index
1a3894666e3041ef56817736f72dcc1e3bb6fc49..833768995f5022e4e404156f8d06c8358cfb3a51
100644
--- a/src/x87/lithium-codegen-x87.cc
+++ b/src/x87/lithium-codegen-x87.cc
@@ -4815,7 +4815,7 @@ void
LCodeGen::DoTransitionElementsKind(LTransitionElementsKind* instr) {
__ mov(FieldOperand(object_reg, HeapObject::kMapOffset),
Immediate(to_map));
// Write barrier.
- DCHECK_NE(instr->temp(), NULL);
+ DCHECK_NOT_NULL(instr->temp());
__ RecordWriteForMap(object_reg, to_map, new_map_reg,
ToRegister(instr->temp()), kDontSaveFPRegs);
} else {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
