LGTM.
On Fri, Oct 30, 2009 at 12:09 PM, <[email protected]> wrote: > Reviewers: Kevin Millikin, > > Description: > Fix new snapshot compilation on ARM. > > Please review this at http://codereview.chromium.org/349001 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/arm/assembler-arm.h > > > Index: src/arm/assembler-arm.h > =================================================================== > --- src/arm/assembler-arm.h (revision 3184) > +++ src/arm/assembler-arm.h (working copy) > @@ -439,16 +439,13 @@ > > // This sets the branch destination (which is in the constant pool on > ARM). > // This is for calls and branches within generated code. > - inline static void set_target_at(Address constant_pool_entry, > - Address target) { > - set_target_address_at(constant_pool_entry, target); > - } > + inline static void set_target_at(Address constant_pool_entry, Address > target); > > // This sets the branch destination (which is in the constant pool on > ARM). > // This is for calls and branches to runtime code. > inline static void set_external_target_at(Address constant_pool_entry, > Address target) { > - set_target_address_at(constant_pool_entry, target); > + set_target_at(constant_pool_entry, target); > } > > // Here we are patching the address in the constant pool, not the actual > call > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
