lgtm with comment.
https://codereview.chromium.org/910683002/diff/1/test/cctest/test-compiler.cc
File test/cctest/test-compiler.cc (right):
https://codereview.chromium.org/910683002/diff/1/test/cctest/test-compiler.cc#newcode419
test/cctest/test-compiler.cc:419: CcTest::isolate(), &script_source,
env.local(), 1, &math);
Would be nicer to have more than one extension object to test that
context chaining (and also shadowing) works.
https://codereview.chromium.org/910683002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
