I'd initialize to PREMONOMORPHIC for crankshaft ICs since cycling through it
seems like unnecessary overhead.
Otherwise, lgtm
https://codereview.chromium.org/892383003/diff/160001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/892383003/diff/160001/src/hydrogen.cc#newcode6598
src/hydrogen.cc:6598: function_language_mode(), UNINITIALIZED);
PREMONOMORPHIC
https://codereview.chromium.org/892383003/diff/160001/src/mips64/lithium-codegen-mips64.cc
File src/mips64/lithium-codegen-mips64.cc (right):
https://codereview.chromium.org/892383003/diff/160001/src/mips64/lithium-codegen-mips64.cc#newcode2914
src/mips64/lithium-codegen-mips64.cc:2914:
CodeFactory::LoadICInOptimizedCode(isolate(), mode,
UNINITIALIZED).code();
PREMONOMORPHIC
https://codereview.chromium.org/892383003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
