lgtm
https://codereview.chromium.org/910773002/diff/120001/src/arm64/deoptimizer-arm64.cc
File src/arm64/deoptimizer-arm64.cc (right):
https://codereview.chromium.org/910773002/diff/120001/src/arm64/deoptimizer-arm64.cc#newcode135
src/arm64/deoptimizer-arm64.cc:135: __ Mov(x3,
Operand(ExternalReference(Isolate::kCEntryFPAddress, isolate())));
May be use UseScratchRegisterScope to allocate scratch register?
https://codereview.chromium.org/910773002/diff/120001/src/cpu-profiler-inl.h
File src/cpu-profiler-inl.h (right):
https://codereview.chromium.org/910773002/diff/120001/src/cpu-profiler-inl.h#newcode42
src/cpu-profiler-inl.h:42: entry->set_deopt_reason(deopt_reason);
Do do we only store last deoptimization reason/position? It'd be worth
mentioning if you are going to change this.
https://codereview.chromium.org/910773002/diff/120001/src/cpu-profiler.h
File src/cpu-profiler.h (right):
https://codereview.chromium.org/910773002/diff/120001/src/cpu-profiler.h#newcode248
src/cpu-profiler.h:248: virtual void CodeDeoptEvent(Code* code, int
bailout_id, Address from,
from -> pc ?
https://codereview.chromium.org/910773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
