On 2015/02/10 09:00:22, jochen (slow) wrote:
https://codereview.chromium.org/912763002/diff/1/src/serialize.h
File src/serialize.h (right):
https://codereview.chromium.org/912763002/diff/1/src/serialize.h#newcode924
src/serialize.h:924: static const int kHeaderSize = (kPayloadLengthOffset
+ 1)
*
sizeof(uint32_t);
if it's supposed to be pointer aligned, why not sizeof(void*)?
This is not the point where we require alignment. Header slots are uint32_t
values. After the header slots, we have variable length uint32_t slots for
reservation sizes and code stub keys. After that comes the payload, which I
want
to align for checksumming.
I now changed the offsets to be actual offsets instead of slot index. It now
resembles the way we define offsets for heap objects.
https://codereview.chromium.org/912763002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
