Reviewers: rossberg,
Message:
rossberg, ptal
https://codereview.chromium.org/912563004/diff/1/src/preparser.cc
File src/preparser.cc (right):
https://codereview.chromium.org/912563004/diff/1/src/preparser.cc#newcode1011
src/preparser.cc:1011: // scope_->SetScopeName(name);
This will be fixed when PreParser starts to handle identifiers etc. as
AstString*s. Setting the scope name of PreParserScope didn't do
anything, so commenting this out doesn't remove any functionality...
Description:
Get rid of PreParserScope.
It's unnecessary; PreParser can just use normal Scopes for the things it
needs
to track. Note: the only functionalities of PreParserScope were keeping
track of
scope type and language mode, and those are now done by Scope. PreParser
doesn't
yet put variables into scopes (that will be done in a follow up).
[email protected]
BUG=
Please review this at https://codereview.chromium.org/912563004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+59, -126 lines):
M src/parser.h
M src/parser.cc
M src/preparser.h
M src/preparser.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
