Reviewers: rossberg,
Message:
rossberg, ptal. moar refactoring.
Description:
Parsing: Make Scope not know about Isolate.
Scope, like Parser, must be able to operate independent of Isolate and the
V8
heap (for background parsing). After the heap-independent phase, there is a
heap
dependent phase, during which we do operations such as scope anaylysis.
This CL makes the phases explicit by not telling Scope about the Isolate too
early (during the heap-independent phase, Scope should know nothing about
Isolate). This decreases the probability of accidental code changes which
would
add heap-dependent operations into the heap-independent phase.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/909093003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+71, -79 lines):
M src/arm/full-codegen-arm.cc
M src/arm64/full-codegen-arm64.cc
M src/compiler/ast-graph-builder.cc
M src/full-codegen.cc
M src/hydrogen.cc
M src/ia32/full-codegen-ia32.cc
M src/preparser.h
M src/runtime/runtime-debug.cc
M src/scopes.h
M src/scopes.cc
M src/x64/full-codegen-x64.cc
M test/cctest/test-parsing.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
