Reviewers: rossberg,
Message:
rossberg, ptal. The second part of "make isolate unaccessible" changes.
Should've done this ages ago.
Description:
Parsing: Make Parser not know about Isolate during background parsing.
Parser must be able to operate independent of Isolate and the V8 heap during
parsing. After the heap-independent phase, there is a heap dependent phase,
during which we internalize strings, handle errors, etc.
This makes Isolate (also via CompilationInfo) unaccessible during parsing,
and
thus decreases the probability of accidental code changes which would add
heap-dependent operations into the heap-independent phase.
Since Isolate is also accessible via CompilationInfo, now CompilationInfo is
only passed to the entry points of parsing, and not stored in Parser.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/908173003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+147, -145 lines):
M src/api.cc
M src/background-parsing-task.cc
M src/parser.h
M src/parser.cc
M src/preparser.h
M test/cctest/test-parsing.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.