PTAL, all platforms done and comments addressed
https://codereview.chromium.org/908883002/diff/20001/src/runtime/runtime-object.cc
File src/runtime/runtime-object.cc (right):
https://codereview.chromium.org/908883002/diff/20001/src/runtime/runtime-object.cc#newcode1304
src/runtime/runtime-object.cc:1304: if (*original_function != *function)
{
On 2015/02/09 17:44:39, arv wrote:
Is this is to set up the prototype from the NewTarget. Maybe add a
comment?
Done.
https://codereview.chromium.org/908883002/diff/20001/test/mjsunit/harmony/classes-experimental.js
File test/mjsunit/harmony/classes-experimental.js (right):
https://codereview.chromium.org/908883002/diff/20001/test/mjsunit/harmony/classes-experimental.js#newcode174
test/mjsunit/harmony/classes-experimental.js:174:
assertTrue(eua.__proto__ === ExtendedUint8Array.prototype);
On 2015/02/09 17:44:40, arv wrote:
Maybe a test with Object.prototype.toString to make sure the instance
is the
right exotic object kind.
Done.
https://codereview.chromium.org/908883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
