Reviewers: arv,
Message:
Deletion of the assert was in
crrev.com/44510671e908d0efc639513d81efcd81e7f14240
Description:
Remove stray comment from ast.cc
This comment used to have a (commented-out) ASSERT attached to it.
But that ASSERT was removed years ago, so the comment is now a
non-sequitar.
Please review this at https://codereview.chromium.org/918453002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -5 lines):
M src/ast.cc
Index: src/ast.cc
diff --git a/src/ast.cc b/src/ast.cc
index
d1e94c87a7ebca0e51b01d192c10f097b8775284..9ef8af411cbd158226f9097359ac235dcf849b54
100644
--- a/src/ast.cc
+++ b/src/ast.cc
@@ -84,11 +84,6 @@ VariableProxy::VariableProxy(Zone* zone, const
AstRawString* name, bool is_this,
void VariableProxy::BindTo(Variable* var) {
DCHECK(!FLAG_harmony_modules || interface_->IsUnified(var->interface()));
DCHECK((is_this() && var->is_this()) || raw_name() == var->raw_name());
- // Ideally CONST-ness should match. However, this is very hard to achieve
- // because we don't know the exact semantics of conflicting (const and
- // non-const) multiple variable declarations, const vars introduced via
- // eval() etc. Const-ness and variable declarations are a complete mess
- // in JS. Sigh...
set_var(var);
set_is_resolved();
var->set_is_used();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
