Reviewers: Benedikt Meurer,
Description:
Relaxed parameter types a bit.
Somehow these changes didn't make it into
https://codereview.chromium.org/915583002 ... :-/
Please review this at https://codereview.chromium.org/919473005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -7 lines):
M src/compiler.h
M src/compiler.cc
M test/cctest/compiler/test-linkage.cc
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index
8961debaab4055f5869c9df0d6b73b1b203b41fa..5d605fd3e2ecbf026bdc65fe4cb486d4f9f10d95
100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -113,8 +113,7 @@ CompilationInfo::CompilationInfo(Handle<JSFunction>
closure, Zone* zone)
}
-CompilationInfo::CompilationInfo(HydrogenCodeStub* stub, Isolate* isolate,
- Zone* zone)
+CompilationInfo::CompilationInfo(CodeStub* stub, Isolate* isolate, Zone*
zone)
: flags_(kLazy | kThisHasUses),
source_stream_(NULL),
osr_ast_id_(BailoutId::None()),
Index: src/compiler.h
diff --git a/src/compiler.h b/src/compiler.h
index
381eb2a7595c6ce4947417f16bc1fda3bf2e1b92..076467a7f26a77259ff364a8ef4c70ac1b39284e
100644
--- a/src/compiler.h
+++ b/src/compiler.h
@@ -427,9 +427,7 @@ class CompilationInfo {
protected:
CompilationInfo(Handle<SharedFunctionInfo> shared_info,
Zone* zone);
- CompilationInfo(HydrogenCodeStub* stub,
- Isolate* isolate,
- Zone* zone);
+ CompilationInfo(CodeStub* stub, Isolate* isolate, Zone* zone);
CompilationInfo(ScriptCompiler::ExternalSourceStream* source_stream,
ScriptCompiler::StreamedSource::Encoding encoding,
Isolate* isolate, Zone* zone);
@@ -562,7 +560,7 @@ class CompilationInfoWithZone: public CompilationInfo {
: CompilationInfo(shared_info, &zone_) {}
explicit CompilationInfoWithZone(Handle<JSFunction> closure)
: CompilationInfo(closure, &zone_) {}
- CompilationInfoWithZone(HydrogenCodeStub* stub, Isolate* isolate)
+ CompilationInfoWithZone(CodeStub* stub, Isolate* isolate)
: CompilationInfo(stub, isolate, &zone_) {}
CompilationInfoWithZone(ScriptCompiler::ExternalSourceStream* stream,
ScriptCompiler::StreamedSource::Encoding
encoding,
Index: test/cctest/compiler/test-linkage.cc
diff --git a/test/cctest/compiler/test-linkage.cc
b/test/cctest/compiler/test-linkage.cc
index
961803d85abf196a8eab5aec29a327f8d1d3b5b2..9136ca42761ba36205fb24d36d9cb960f5310b91
100644
--- a/test/cctest/compiler/test-linkage.cc
+++ b/test/cctest/compiler/test-linkage.cc
@@ -74,7 +74,7 @@ TEST(TestLinkageJSFunctionIncoming) {
TEST(TestLinkageCodeStubIncoming) {
Isolate* isolate = CcTest::InitIsolateOnce();
- CompilationInfoWithZone info(static_cast<HydrogenCodeStub*>(NULL),
isolate);
+ CompilationInfoWithZone info(static_cast<CodeStub*>(NULL), isolate);
Linkage linkage(info.zone(), &info);
// TODO(titzer): test linkage creation with a bonafide code stub.
// this just checks current behavior.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
