Reviewers: dcarney,
Message:
PTAL
Description:
Reland r26549 "Fix IsWeakObjectInOptimizedCode predicate to also include
property cells."
BUG=v8:3882
LOG=NO
Please review this at https://codereview.chromium.org/913093002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -1 lines):
M src/objects-inl.h
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index
75e5ae39b8ca7f7f8a1e0662326f067865f90b99..383bc76a25018f1844afe76e9394c3dac1844b01
100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -5242,7 +5242,11 @@ bool Code::IsWeakObjectInOptimizedCode(Object*
object) {
return Map::cast(object)->CanTransition() &&
FLAG_weak_embedded_maps_in_optimized_code;
}
- if (object->IsCell()) object = Cell::cast(object)->value();
+ if (object->IsCell()) {
+ object = Cell::cast(object)->value();
+ } else if (object->IsPropertyCell()) {
+ object = PropertyCell::cast(object)->value();
+ }
if (object->IsJSObject()) {
return FLAG_weak_embedded_objects_in_optimized_code;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.