Reviewers: Michael Starzinger, Weiliang, danno,
Message:
Hello, Michael.
PTAL.
thanks
Description:
Copy the corresponding opt_count_and_bailout_reason info when invoking
Runtime_SetCode.
This error is exposed by this CL:
https://codereview.chromium.org/817293005.
This CL set all Buildin JS function to optimization_disabled.
And set the bailout reason to "kBuiltinFunctionCannotBeOptimized". But in
Runtime_SetCode() function.
It copied the the compiler_hints which include the "bool
optimization_disabled" value,
But the corresponding Bailout reason is not copied.
This leads to the check error
in "CompilationInfo::AbortOptimization(...)"
function.
This issue is exposed on turbofan unsupported X87 platform. Crankshaft is
invoked to compile
the typed array function Uint8Array.
BUG=
Please review this at https://codereview.chromium.org/917643002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -0 lines):
M src/runtime/runtime-function.cc
Index: src/runtime/runtime-function.cc
diff --git a/src/runtime/runtime-function.cc
b/src/runtime/runtime-function.cc
index
0a9cd6313f53fc505f5c671cb9219649d289006f..217e9999bac9b9d3f990e792bf275a6d4cc0dc86
100644
--- a/src/runtime/runtime-function.cc
+++ b/src/runtime/runtime-function.cc
@@ -279,6 +279,8 @@ RUNTIME_FUNCTION(Runtime_SetCode) {
target_shared->set_end_position(source_shared->end_position());
bool was_native = target_shared->native();
target_shared->set_compiler_hints(source_shared->compiler_hints());
+ target_shared->set_opt_count_and_bailout_reason(
+ source_shared->opt_count_and_bailout_reason());
target_shared->set_native(was_native);
target_shared->set_profiler_ticks(source_shared->profiler_ticks());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
