Reviewers: dcarney,
Description:
Removed most of the bogus CompilationInfo constructor calls.
A CompilationInfo constructed from just an Isolate* and a Zone* is in
weird an inconsistent state (calling e.g. flags() on it will crash),
so we need to avoid them. This CL removes almost all of them, the
remaining 2 call sites in (for testing only) will be handled in a
separate CL. Things which have been changed:
* Linkage is basically a decorator for CallDescriptor now.
* ChangeLowering doesn't need Linkage at all.
* JSGenericLowering doesn't need a full CompilationInfo*, just a
single flag.
* JSContextSpecializer doesn't need the full CompilationInfo, just a
Context.
* Removed unused CompilationInfo from SimplifiedLoweringTester.
This nicely decouples things already a bit more, but there's still
work to do...
Please review this at https://codereview.chromium.org/899803003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+64, -115 lines):
M src/compiler/change-lowering.h
M src/compiler/change-lowering.cc
M src/compiler/js-context-specialization.h
M src/compiler/js-context-specialization.cc
M src/compiler/js-generic-lowering.h
M src/compiler/js-generic-lowering.cc
M src/compiler/linkage.h
M src/compiler/linkage.cc
M src/compiler/pipeline.cc
M test/cctest/compiler/test-changes-lowering.cc
M test/cctest/compiler/test-instruction.cc
M test/cctest/compiler/test-js-context-specialization.cc
M test/cctest/compiler/test-linkage.cc
M test/cctest/compiler/test-simplified-lowering.cc
M test/unittests/compiler/change-lowering-unittest.cc
M test/unittests/compiler/instruction-selector-unittest.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
