On 2015/02/11 14:35:26, vogelheim wrote:
lgtm


Not sure if this is a silly question, but why is src/base/logging.h only
included if !V8_SHARED?

V8_SHARED is only set for the shared library build, which can then only use the
stuff exported in include/v8.h, iirc.

https://codereview.chromium.org/913173002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to