Reviewers: Weiliang,
Message:
PTAL.
thanks
Description:
X87: Propagate Deopt reason to cpu-profiler
port 86cae1633caa31f2225b6932850fb13d3a21cf59 (r26545)
original commit message:
1) Deoptimizer::Reason was replaced with Deoptimizer::DeoptInfo
because it also has raw position. Also the old name clashes with
DeoptReason enum.
2) c_entry_fp assignment call was added to EntryGenerator::Generate
So we can calculate sp and have a chance to record the stack for the
deopting function.
btw it makes the test stable.
3) new kind of CodeEvents was added to cpu-profiler
4) GetDeoptInfo method was extracted from PrintDeoptLocation.
So it could be reused in cpu profiler.
BUG=
Please review this at https://codereview.chromium.org/912403003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -0 lines):
M src/x87/deoptimizer-x87.cc
Index: src/x87/deoptimizer-x87.cc
diff --git a/src/x87/deoptimizer-x87.cc b/src/x87/deoptimizer-x87.cc
index
0e53a0e8db93fef860fd0668b51d9da11a4f0b6e..262535efa1d01eb4f9eeaec539cda295ceace7f0
100644
--- a/src/x87/deoptimizer-x87.cc
+++ b/src/x87/deoptimizer-x87.cc
@@ -241,6 +241,9 @@ void Deoptimizer::EntryGenerator::Generate() {
__ pushad();
+ ExternalReference c_entry_fp_address(Isolate::kCEntryFPAddress,
isolate());
+ __ mov(Operand::StaticVariable(c_entry_fp_address), ebp);
+
// GP registers are safe to use now.
// Save used x87 fp registers in correct position of previous reserve
space.
Label loop, done;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
