Reviewers: Weiliang,
Message:
PTAL.
Description:
X87: Parsing: Make Scope not know about Isolate.
port 5d68529be240a1fc9fcc67c8950ead4baf7604e4 (r26546)
original commit message:
Parsing: Make Scope not know about Isolate.
Scope, like Parser, must be able to operate independent of Isolate and
the V8
heap (for background parsing). After the heap-independent phase, there is
a
heap
dependent phase, during which we do operations such as scope anaylysis.
This CL makes the phases explicit by not telling Scope about the Isolate
too
early (during the heap-independent phase, Scope should know nothing about
Isolate). This decreases the probability of accidental code changes which
would
add heap-dependent operations into the heap-independent phase.
BUG=
Please review this at https://codereview.chromium.org/913163003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/x87/full-codegen-x87.cc
Index: src/x87/full-codegen-x87.cc
diff --git a/src/x87/full-codegen-x87.cc b/src/x87/full-codegen-x87.cc
index
a1c2960b4d70637de8dfaf685d1af06f0e0f281d..bfc10cc3c8f7672745b2ed36337f73d8a8e5ffaa
100644
--- a/src/x87/full-codegen-x87.cc
+++ b/src/x87/full-codegen-x87.cc
@@ -190,7 +190,7 @@ void FullCodeGenerator::Generate() {
// Argument to NewContext is the function, which is still in edi.
if (FLAG_harmony_scoping && info->scope()->is_script_scope()) {
__ push(edi);
- __ Push(info->scope()->GetScopeInfo());
+ __ Push(info->scope()->GetScopeInfo(info->isolate()));
__ CallRuntime(Runtime::kNewScriptContext, 2);
} else if (heap_slots <= FastNewContextStub::kMaximumSlots) {
FastNewContextStub stub(isolate(), heap_slots);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
