Please take another look: comments addressed + ports done
https://codereview.chromium.org/917753002/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/917753002/diff/1/src/ia32/full-codegen-ia32.cc#newcode3108
src/ia32/full-codegen-ia32.cc:3108: if
(expr->expression()->IsSuperReference()) {
On 2015/02/11 14:53:48, arv wrote:
This is dead code... see https://codereview.chromium.org/911223002/
Will rebase
https://codereview.chromium.org/917753002/diff/1/src/ia32/full-codegen-ia32.cc#newcode4084
src/ia32/full-codegen-ia32.cc:4084:
On 2015/02/11 14:53:48, arv wrote:
remove empty line
Done.
https://codereview.chromium.org/917753002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/917753002/diff/1/src/parser.cc#newcode292
src/parser.cc:292: AssertIsConstruct(body, pos);
On 2015/02/11 14:53:49, arv wrote:
Can you rename this to CreateAssertIsConstruct or
AddAssertIsConstruct?
Done.
https://codereview.chromium.org/917753002/diff/1/src/parser.cc#newcode3924
src/parser.cc:3924: body->Add(if_statement, zone());
On 2015/02/11 14:53:49, arv wrote:
Another option would be to call this CreateAssertIsConstruct and do
the add in
the caller.
I like Add because it skips on FLAG_experimental_classes, but that does
not matter too much.
The semantics we need is always create and add, so keeping Add
https://codereview.chromium.org/917753002/diff/1/test/mjsunit/harmony/classes-experimental.js
File test/mjsunit/harmony/classes-experimental.js (right):
https://codereview.chromium.org/917753002/diff/1/test/mjsunit/harmony/classes-experimental.js#newcode257
test/mjsunit/harmony/classes-experimental.js:257: var f =
Subclass2.bind({}, 3, 4);
On 2015/02/11 14:53:49, arv wrote:
var -> let
Done.
https://codereview.chromium.org/917753002/diff/1/test/mjsunit/harmony/classes-experimental.js#newcode284
test/mjsunit/harmony/classes-experimental.js:284:
assertTrue(eua.__proto__ === ExtendedUint8Array.prototype);
On 2015/02/11 14:53:49, arv wrote:
assertSame or assertEquals
Done.
https://codereview.chromium.org/917753002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
