lgtm
https://codereview.chromium.org/904863002/diff/40001/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/904863002/diff/40001/src/types.cc#newcode519
src/types.cc:519: return BitsetType::Is(SEMANTIC(this->BitsetLub()),
that->AsBitset());
On 2015/02/11 16:10:47, jarin wrote:
On 2015/02/11 12:34:10, rossberg wrote:
> Don't you need SEMANTIC on 'that' as well?
I do not think so. That is purely because the representation of the
right hand
side cannot possibly affect the result (left hand side representation
is empty,
so it is always subtype of the right hand side representation). I
agree that
this is not quite obvious, and perhaps a premature optimization.
Ah, right.
https://codereview.chromium.org/904863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
