http://codereview.chromium.org/354024/diff/1/5 File src/arm/fast-codegen-arm.cc (right):
http://codereview.chromium.org/354024/diff/1/5#newcode108 Line 108: { Comment cmnt(masm_, "Return sequence"); You don't need a block inside a block. I would put this comment only in the case that you are emitting the return sequence, not in the case that you are jumping to it. Consider making this a "[ " comment, so the end is marked as well. http://codereview.chromium.org/354024/diff/1/5#newcode113 Line 113: SetReturnPosition(function_); This can't be right, can it? It says that this return corresponds to the source location of the end of the function, even for return statements. I think you need to call SetReturnPosition before the 'return unefined' call to EmitReturnSequence, and SetStatementPosition before the other ones. Or, consider passing the source position to EmitReturnSequence (then you can probably get rid of SetReturnPosition completely). http://codereview.chromium.org/354024/diff/1/2 File src/fast-codegen.h (right): http://codereview.chromium.org/354024/diff/1/2#newcode59 Line 59: void EmitReturnSequence(); Move this down by all the other "EmitXXX" platform-specific helpers. Add a comment that it is platform specific. http://codereview.chromium.org/354024 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
