Reviewers: Søren Gjesse, Description: Insert call to CodeForFunctionPosition in the ARM code generator.
(== SetFunctionPosition in the top-level compiler) IA32 and X64 already do this at the beginning of CodeGenerator::gencode Please review this at http://codereview.chromium.org/354026 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/codegen-arm.cc M src/arm/fast-codegen-arm.cc Index: src/arm/fast-codegen-arm.cc =================================================================== --- src/arm/fast-codegen-arm.cc (revision 3206) +++ src/arm/fast-codegen-arm.cc (working copy) @@ -52,7 +52,7 @@ // frames-arm.h for its layout. void FastCodeGenerator::Generate(FunctionLiteral* fun) { function_ = fun; - // ARM does NOT call SetFunctionPosition. + SetFunctionPosition(fun); __ stm(db_w, sp, r1.bit() | cp.bit() | fp.bit() | lr.bit()); // Adjust fp to point to caller's fp. Index: src/arm/codegen-arm.cc =================================================================== --- src/arm/codegen-arm.cc (revision 3206) +++ src/arm/codegen-arm.cc (working copy) @@ -144,6 +144,9 @@ // cp: callee's context void CodeGenerator::GenCode(FunctionLiteral* fun) { + // Record the position for debugging purposes. + CodeForFunctionPosition(fun); + ZoneList<Statement*>* body = fun->body(); // Initialize state. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
