Reviewers: ulan,
Description:
Start with a more conservative initial old generation size.
BUG=
Please review this at https://codereview.chromium.org/934803002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+6, -2 lines):
M src/heap/heap.h
M src/heap/heap.cc
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index
8ff27dc32a21a1931a7ec3524b035589c285dc19..d4cd78ebdaa7f1161ff56ea45a5cfdf6f6fe3e8e
100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -67,7 +67,8 @@ Heap::Heap()
initial_semispace_size_(Page::kPageSize),
target_semispace_size_(Page::kPageSize),
max_old_generation_size_(700ul * (kPointerSize / 4) * MB),
- initial_old_generation_size_(max_old_generation_size_),
+ initial_old_generation_size_(max_old_generation_size_ /
+ kInitalOldGenerationLimitFactor),
old_generation_size_configured_(false),
max_executable_size_(256ul * (kPointerSize / 4) * MB),
// Variables set based on semispace_size_ and old_generation_size_ in
@@ -5281,7 +5282,8 @@ bool Heap::ConfigureHeap(int max_semi_space_size, int
max_old_space_size,
if (FLAG_initial_old_space_size > 0) {
initial_old_generation_size_ = FLAG_initial_old_space_size * MB;
} else {
- initial_old_generation_size_ = max_old_generation_size_ / 2;
+ initial_old_generation_size_ =
+ max_old_generation_size_ / kInitalOldGenerationLimitFactor;
}
old_generation_allocation_limit_ = initial_old_generation_size_;
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index
15eb0820f038e1b3ac23e4f3d341cc9a540cb7b9..23d634001b1a8ce2b2594fbf62c957d2f85f860c
100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -1084,6 +1084,8 @@ class Heap {
static const intptr_t kMinimumOldGenerationAllocationLimit =
8 * (Page::kPageSize > MB ? Page::kPageSize : MB);
+ static const int kInitalOldGenerationLimitFactor = 7;
+
static const int kPointerMultiplier = i::kPointerSize / 4;
// The new space size has to be a power of 2. Sizes are in MB.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
