Reviewers: Søren Gjesse, Description: Remove TODO comments in code generation for typeof subexpressions.
The 'phantom' property used for evaluation of typeof does not have a source-code position, just like other phantom properties in V8 (eg, global variables, parameters rewritten to arguments accesses, etc.). Please review this at http://codereview.chromium.org/361004 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/codegen-arm.cc M src/ia32/codegen-ia32.cc M src/x64/codegen-x64.cc Index: src/ia32/codegen-ia32.cc =================================================================== --- src/ia32/codegen-ia32.cc (revision 3212) +++ src/ia32/codegen-ia32.cc (working copy) @@ -547,8 +547,6 @@ // load to make sure we do not get reference errors. Slot global(variable, Slot::CONTEXT, Context::GLOBAL_INDEX); Literal key(variable->name()); - // TODO(1241834): Fetch the position from the variable instead of using - // no position. Property property(&global, &key, RelocInfo::kNoPosition); Reference ref(this, &property); ref.GetValue(); Index: src/x64/codegen-x64.cc =================================================================== --- src/x64/codegen-x64.cc (revision 3212) +++ src/x64/codegen-x64.cc (working copy) @@ -4812,8 +4812,6 @@ // load to make sure we do not get reference errors. Slot global(variable, Slot::CONTEXT, Context::GLOBAL_INDEX); Literal key(variable->name()); - // TODO(1241834): Fetch the position from the variable instead of using - // no position. Property property(&global, &key, RelocInfo::kNoPosition); Reference ref(this, &property); ref.GetValue(); Index: src/arm/codegen-arm.cc =================================================================== --- src/arm/codegen-arm.cc (revision 3212) +++ src/arm/codegen-arm.cc (working copy) @@ -573,8 +573,6 @@ // load to make sure we do not get reference errors. Slot global(variable, Slot::CONTEXT, Context::GLOBAL_INDEX); Literal key(variable->name()); - // TODO(1241834): Fetch the position from the variable instead of using - // no position. Property property(&global, &key, RelocInfo::kNoPosition); Reference ref(this, &property); ref.GetValueAndSpill(); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
