Thanks for the suggestions! I run in some error after the changes. See below.

https://codereview.chromium.org/931233002/diff/60001/tools/gcmole/gcmole.lua
File tools/gcmole/gcmole.lua (right):

https://codereview.chromium.org/931233002/diff/60001/tools/gcmole/gcmole.lua#newcode409
tools/gcmole/gcmole.lua:409: local function SearchForErrors(filename,
lines)
On 2015/02/18 10:56:49, Vyacheslav Egorov (Google) wrote:
if you change signature of this function and `parse` to (filename,
iterator,
lines) and do

for l in iterator(lines) do ... end

then you can write

func(..., ipairs, current) instead of IterTable.

and

func(..., pipe.lines, pipe) instead of func(..., pipe:lines())

hmm but that would lead to
for l in ipairs(current) do ... end
and then l is a number not the value. I think I still need to wrap the
iterator somehow, either in the sequential case or the other - or is
there another way?

https://codereview.chromium.org/931233002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to