Reviewers: Hannes Payer,
Message:
PTAL
https://codereview.chromium.org/938693002/diff/1/src/isolate.cc
File src/isolate.cc (left):
https://codereview.chromium.org/938693002/diff/1/src/isolate.cc#oldcode2602
src/isolate.cc:2602:
counters()->detached_context_age_in_gc()->AddSample(mark_sweeps);
We need to sample all detached contexts, not only the collected ones
because if there is a memory leak then the leaked context will never be
collected.
Description:
Fix sampling of V8.DetachedContextAgeInGC histogram.
BUG=
Please review this at https://codereview.chromium.org/938693002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -2 lines):
M src/isolate.cc
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index
8c3fce930ed6732c281a46ed83cd30a915a52b39..7319af41c181d6ea8f89251e9f5e1132a97c28b8
100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2598,9 +2598,8 @@ void Isolate::CheckDetachedContextsAfterGC() {
detached_contexts->set(new_length, Smi::FromInt(mark_sweeps + 1));
detached_contexts->set(new_length + 1, cell);
new_length += 2;
- } else {
- counters()->detached_context_age_in_gc()->AddSample(mark_sweeps);
}
+ counters()->detached_context_age_in_gc()->AddSample(mark_sweeps + 1);
}
if (FLAG_trace_detached_contexts) {
PrintF("%d detached contexts are collected out of %d\n",
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
