LGTM, with one suggested small change.
The nop() should be included Block'd region. The padding won't change
if/when
this code block is moved by gc, since the start of the new assembly buffer
will
be aligned to 8 on 64-bit platforms. The offset within the buffer will stay
the
same.
https://codereview.chromium.org/940453003/diff/1/src/compiler/mips64/code-generator-mips64.cc
File src/compiler/mips64/code-generator-mips64.cc (right):
https://codereview.chromium.org/940453003/diff/1/src/compiler/mips64/code-generator-mips64.cc#newcode1068
src/compiler/mips64/code-generator-mips64.cc:1068: }
I agree that you should include the nop() in the Block..For scope, but
there is no penalty for blocking for one additional instruction, so I
suggest moving that out of the if(), and always use (case_count * 2 +
7).
I think that will enhance readability, and make the adding the padding
nop() more clear.
https://codereview.chromium.org/940453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
