Reviewers: titzer, jarin,
Message:
Hi Ben, hi Jaro, here is the frame change we've discussed. Thanks for the
look!
--Michael
Description:
Put the type feedback vector in the unoptimized JavaScript frame.
It's costly to look the vector up in the SharedFunctionInfo. By placing
it in the frame, we save loads. Optimized frames don't have it because
we typically inline several functions in one optimized function, and
the feedback vectors are different.
BUG=
Please review this at https://codereview.chromium.org/942513002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+277, -72 lines):
M src/arm/code-stubs-arm.cc
M src/arm/frames-arm.h
M src/arm/full-codegen-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/arm/macro-assembler-arm.h
M src/arm/macro-assembler-arm.cc
M src/arm64/code-stubs-arm64.cc
M src/arm64/frames-arm64.h
M src/arm64/full-codegen-arm64.cc
M src/arm64/lithium-codegen-arm64.cc
M src/arm64/macro-assembler-arm64.h
M src/arm64/macro-assembler-arm64.cc
M src/compiler/arm/code-generator-arm.cc
M src/compiler/arm64/code-generator-arm64.cc
M src/compiler/ia32/code-generator-ia32.cc
M src/compiler/x64/code-generator-x64.cc
M src/deoptimizer.h
M src/deoptimizer.cc
M src/frames.h
M src/frames.cc
M src/ia32/code-stubs-ia32.cc
M src/ia32/deoptimizer-ia32.cc
M src/ia32/frames-ia32.h
M src/ia32/full-codegen-ia32.cc
M src/ia32/lithium-codegen-ia32.cc
M src/ia32/macro-assembler-ia32.h
M src/ia32/macro-assembler-ia32.cc
M src/x64/code-stubs-x64.cc
M src/x64/frames-x64.h
M src/x64/full-codegen-x64.cc
M src/x64/lithium-codegen-x64.cc
M src/x64/macro-assembler-x64.h
M src/x64/macro-assembler-x64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.