On 2015/02/19 14:40:44, michael_dawson wrote:
I did not use git new-branch so rebuilt using that. I tried to specify
BUG=936813002 so that it would upload the patch on this review, but it
did not
do that and created 936813002 instead.
One more question. When I do a rebase should I do something other than
git pull --rebase origin master
I think the correct workflow is (at least that's mine :-) :
gclient sync # make sure all dependencies are up-to-date
git pull --rebase # make sure your master is up-to-date
git new-branch my-cool-branch # switch to a new correctly tracked branch
git cl issue 936813002 # associate the branch with that issue
<make the actual local modifications to the sources>
git commit -a -m "I did this and that..."
git pull --rebase # make sure your branch is up-to-date
git cl upload
https://codereview.chromium.org/936813002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
