https://codereview.chromium.org/934323004/diff/1/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/934323004/diff/1/src/messages.js#newcode179
src/messages.js:179: duplicate_export: ["Cannot export '",
"%0", "' more than once"],
On 2015/02/19 15:05:44, arv wrote:
I think the error message should contain "duplicate". How about?
"Duplicate export of '", %0, "'"
Done.
https://codereview.chromium.org/934323004/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/934323004/diff/1/src/parser.cc#newcode1589
src/parser.cc:1589: // TODO(adamk): Possibly report this error at the
right place.
On 2015/02/19 15:05:44, arv wrote:
Maybe pass one more list with the locations to ParseExportClause.
Hmm. There will be cases, with "export * from ...", where we'll end up
with export conflicts at the linking stage, and this won't help provide
better error messages in those cases. But I expect "export * from" to be
one of the last things I do, so I can refactor as needed when I get
around to that. It's looking like it would be useful to have the
locations of each export available later in several places.
Added a list of locations for now, I think there's more refactoring I
can do here. Also added tests for these error messages (to help with
refactoring later).
https://codereview.chromium.org/934323004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
