On 2015/02/20 14:54:05, Vyacheslav Egorov (Google) wrote:
I think when I was copy pasting code for my comment I did it super
wrong :)
https://codereview.chromium.org/935393002/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/935393002/diff/20001/src/hydrogen.cc#newcode10494
src/hydrogen.cc:10494: ? HConstant::cast(right)->StringValue()
should be left here.
https://codereview.chromium.org/935393002/diff/20001/src/hydrogen.cc#newcode10497
src/hydrogen.cc:10497: left->IsConstant() &&
HConstant::cast(left)->HasStringValue()
should be right-> here.
I should have double checked :)
https://codereview.chromium.org/935393002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
