https://codereview.chromium.org/947443005/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/947443005/diff/1/src/objects.cc#newcode803
src/objects.cc:803: uint32_t hash =
ComputeLongHash(double_to_uint64(static_cast<double>(num)));
On 2015/02/20 19:19:08, arv wrote:
I tried a few other approaches here but it is important that we
compute the same
hash code here as in the heap number case.
This is fine for now, and the right approach for this patch (changing
only one thing at a time) but soon I'll be creating a patch to use a
32-bit hash function for Smis, and have code in the IsHeapNumber branch
to compute the same 32-bit hash for Smi-representable doubles.
https://codereview.chromium.org/947443005/diff/1/src/objects.cc#newcode809
src/objects.cc:809: if (i::IsMinusZero(num)) num = 0;
Nit: shouldn't need the "i::" prefix here.
https://codereview.chromium.org/947443005/diff/1/test/mjsunit/es6/map-set-minus-zero.js
File test/mjsunit/es6/map-set-minus-zero.js (right):
https://codereview.chromium.org/947443005/diff/1/test/mjsunit/es6/map-set-minus-zero.js#newcode1
test/mjsunit/es6/map-set-minus-zero.js:1: // Copyright 2014 the V8
project authors. All rights reserved.
Nit: 2015
https://codereview.chromium.org/947443005/diff/1/test/mjsunit/es6/map-set-minus-zero.js#newcode7
test/mjsunit/es6/map-set-minus-zero.js:7: var t = new Map();
Please add a Set codepath as well.
https://codereview.chromium.org/947443005/diff/1/test/mjsunit/es6/map-set-minus-zero.js#newcode20
test/mjsunit/es6/map-set-minus-zero.js:20: assertEquals(t.size, 0);
Please invert all the assertEquals() calls in this file: format is
assertEquals(expected, actual).
https://codereview.chromium.org/947443005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
