On 2015/02/20 13:21:24, michael_dawson wrote:
On 2015/02/19 20:32:38, Hannes Payer wrote:
> On 2015/02/19 18:26:49, michael_dawson wrote:
> > On 2015/02/19 17:47:24, Hannes Payer wrote:
> > > What is the performance impact of that change? And why does it
improve
> > > performance? I guess you observe the benefit of having an initial
larger
> > > semi-space size (4M). Instead of increasing the page size, you could
start
> > with
> > > a larger semi-space size on ppc.
> >
> > When enabled with other performance optmizations, increasing the
pagesize
got
> > us 1-2%. Since the machine page size is larger for PPC (64k) the
> guard/metadata
> > pages consume a larger portion of the default 1MB heap page size.
>
> 1-2% on which benchmarks?
> how does it compare to 1M pages with a --min-semi-space-size=4?
It was 1-2% on octane. We'll have to try out with
--min-semi-space-size=4 and
compare
We are still doing runs to capture the current benefit of the page size
change
given changes to the OOL implementation versus the option suggested.
Separately,
most of the changes in this patch are to make the tests use the page size
define
as opposed to a hard coded assumption. Would it make sense to commit those
changes
and then submit a second review once we've captured the current benefit and
comparison to --min-semi-space-size=4 ? If so I can update this patch to
move
the change to the page size for PPC.
https://codereview.chromium.org/910333004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
