http://codereview.chromium.org/371065/diff/1/2 File src/string.js (right):
http://codereview.chromium.org/371065/diff/1/2#newcode390 Line 390: // If either start or end of match is missing use undefined. On 2009/11/09 10:22:22, Erik Corry wrote: > I don't think the start or end can be missing. Good point. In that case there wouldn't be a match. Removed the check. > I think it's probably worth moving inlining outside the do loop so you don't > have to check numberOfCaptures for every iteration. I tried this. Didn't make much difference, so I'd prefer not to duplicate the loop. http://codereview.chromium.org/371065 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
