Nice.
https://codereview.chromium.org/947683002/diff/20001/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/947683002/diff/20001/src/collection.js#newcode40
src/collection.js:40: if (keyIsNaN && IS_NUMBER(candidate) &&
NUMBER_IS_NAN(candidate)) {
Nice optimization to get around the NaN SameValueZero inefficiency.
https://codereview.chromium.org/947683002/diff/20001/src/collection.js#newcode40
src/collection.js:40: if (keyIsNaN && IS_NUMBER(candidate) &&
NUMBER_IS_NAN(candidate)) {
Nice optimization to get around the NaN SameValueZero inefficiency.
https://codereview.chromium.org/947683002/diff/20001/src/collection.js#newcode218
src/collection.js:218: while (%SetIteratorNext(iterator, value_array)) {
This one can get much faster now that we have access to the underlying
elements. Lets revisit.
https://codereview.chromium.org/947683002/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/947683002/diff/20001/src/hydrogen.cc#newcode12105
src/hydrogen.cc:12105: DCHECK(call->arguments()->length() == 3);
2
https://codereview.chromium.org/947683002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/947683002/diff/20001/src/objects.cc#newcode810
src/objects.cc:810: return Smi::FromInt(FastD2I(num))->GetHash();
Why not call ComputeIntegerHash here directly so we do not have to check
if it is a Smi again?
https://codereview.chromium.org/947683002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
